Skip to content

Conversation

@ErichDonGubler
Copy link
Contributor

@ErichDonGubler ErichDonGubler commented Jan 31, 2025

No description provided.

@ErichDonGubler ErichDonGubler force-pushed the clang-driver_mode_cl-testing branch 3 times, most recently from b3a95bc to 502bc1f Compare February 3, 2025 22:20
Copy link
Contributor

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it so far!

@ErichDonGubler ErichDonGubler force-pushed the clang-driver_mode_cl-testing branch 2 times, most recently from 38843c7 to 6139264 Compare February 4, 2025 01:39
@ErichDonGubler ErichDonGubler marked this pull request as ready for review February 4, 2025 01:46
@ErichDonGubler
Copy link
Contributor Author

Just confirmed that this test fails prior to #1378, so I'm satisfied with where it's at.

@ErichDonGubler ErichDonGubler force-pushed the clang-driver_mode_cl-testing branch from 6139264 to 8139264 Compare February 4, 2025 01:50
Copy link
Contributor

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@NobodyXu NobodyXu merged commit a49184e into rust-lang:main Feb 4, 2025
52 checks passed
@ErichDonGubler ErichDonGubler deleted the clang-driver_mode_cl-testing branch February 5, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants